Use ConfigurationCompat for locale access in I18nManagerModule#55663
Closed
alanleedev wants to merge 1 commit intofacebook:mainfrom
Closed
Use ConfigurationCompat for locale access in I18nManagerModule#55663alanleedev wants to merge 1 commit intofacebook:mainfrom
alanleedev wants to merge 1 commit intofacebook:mainfrom
Conversation
Summary: Replace the direct `configuration.locales[0]` call with `ConfigurationCompat.getLocales()` from AndroidX, which handles the API level check internally. Falls back to `Locale.getDefault()` if the locale list is empty. Changelog: [Internal] ---- Differential Revision: D93943818
meta-cla
bot
added
the
CLA Signed
|
@alanleedev has exported this pull request. If you are a Meta employee, you can view the originating Diff in D93943818. |
|
This pull request has been merged in cd4a2bd. |
Collaborator
|
This pull request was successfully merged by @alanleedev in cd4a2bd When will my fix make it into a release? | How to file a pick request? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
Replace the direct
configuration.locales[0]call withConfigurationCompat.getLocales()from AndroidX, which handles the API level check internally. Falls back toLocale.getDefault()if the locale list is empty.Changelog: [Internal]
Differential Revision: D93943818